Merged
Conversation
All methods now have specific-arity paths up to 3 arguments.
The Region changes in JRuby's regex engine require that we support both the old and new API for a while. Unfortunately the only version of JRuby that contains both APIs is 9.4.1.0 so we have to at least build against that version. Testing can occur against any version, but for now this is the simplest way to get CI green.
Contributor
Author
|
@mrkn Could we do a release soon? These are small changes but also minor perf improvements and good cleanup. |
Member
|
I can do it. |
Member
|
Done. |
headius
added a commit
to headius/jruby
that referenced
this pull request
Oct 19, 2023
headius
added a commit
to headius/jruby
that referenced
this pull request
Jan 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few minor tweaks.
values_atmethod for low arity calls